'outputComplex' argument removed from Sentinel-1 terrain correction

The descriptions about the changes are generally provided in the release notes. If we failed in doing that, it’s our fault. We will try to do better in future. Thanks for the suggestion!

2 Likes

Great to hear. Where are these release notes normally hosted? Then next time, I would know where to look!

I would like to raise that, regardless of ESA suggestions, we fully rely on this option for our processing and services generating substantial amounts of business based on S1.

@jun_lu can you share the location where the release notes are hosted? This would help a lot while searching for updates.

I think all the information can be found in the STEP JIRA board Dashboard - JIRA

@jun_lu I’m sorry, but as far as I can see with my current access, the Jira board only contains issues and no release notes. Also, when I search for the removed argument outputComplex, no relevant results pop up.

The GitHub of SNAP has a section about releases, but there is no information about the actual changes.

See https://github.com/senbox-org/snap-desktop/releases/tag/8.0.8

The Sentinel-1 toolbox tags contain even less information. See https://github.com/senbox-org/s1tbx/tags

Is there another place that might contain the information I’m looking for?

I agree with @egremmer. It would be great if there was an improvement in this regard and if we could get some proper release notes in the near future!

cc @johntruckenbrodt

2 Likes

I agree with all said before, I ran into this issue here and nobody answered back then.
Releasing the notes and stating what will be soon deprecated would be greatly appreciated :pray:

1 Like

@remi-braun I think that you ran into the same issue I described.

Is there anybody from the SNAP team or any of the companies involved who can comment on the release notes policy of SNAP?

Yes, this is what I meant, sorry for not being clear :sweat_smile:

No worries. It is good to see that I’m not the only one struggling with this issue. :slight_smile:

1 Like

Hello @egremmer,

Regarding the release notes policy of SNAP, the links of specific release notes are provided under the tabs of Help → About SNAP.
I agree with you that the link for S1TBX is not pointing to the right location (it shows only the changes of 8.0 major version), it should be similar with the one for S2TBX for example:
Release Notes

Optionally, a simple JIRA list extraction (plus additional details if needed) can be mentioned on github release notes, as for s2tbx for example:
ReleaseNotes.md

@jun_lu please take this into consideration for the next s1tbx minor release, so that the users are informed about the changes.
Thank you :slight_smile:

2 Likes

Hi @oana_hogoiu,

The release notes of s2tbx contain the minor release changes, which is great! These are missing for s1tbx, see https://github.com/senbox-org/s1tbx/blob/8.x/ReleaseNotes.md

If the release notes of the minor changes of s1tbx could be published on github, that would be great.
Thank you for pointing to the location and addressing the issue, this is much appreciated!

Thanks @jun_lu for the fix.
From here [SITBX-905] - JIRA I can’t see in which release version of the s1tbx / snap the fix is included… Which one is it?

This method produces unusable incorrect geocoded phases so we would like to remove this option to prevent people from making mistakes.

Hi Marcus,
I like to challenge your statement that this operator produces “unusable” data. I believe the S1 based services we provide, and which rely on the complex output of this operator, prove quite the opposite. I agree that direct naive use of this operator for complex output produces data that cannot be used for the common S1 typical usecases. However, with proper pre-processing and conditioning of S1 data before applying this operator it in fact produces complex output data with substantial added value. We therefore kindly request ESA and the toolbox developers to leave the complex option in (at least on the gpt/api level) and to keep a wide view on usecases for which the toolbox and its operators are used beyond the standard applications they are themselves the experts on. Especially in the case of “removing functionality” it would be great to consult the community in advance to avoid potential damage to the broader S1 value chain.

CC @jun_lu

Ok, we can keep this functionality for backwards compatibility. I assume you are basing some services on coherence computed from the phase? It should be usable over non-complex terrain I guess.

A JIRA ticket ([SITBX-924] - JIRA) has been created to track the issue. We will work on it. Thank you.

1 Like

The complex output functionality has been restored and it should be in the next release.

1 Like

Hello, I want to use this function now, is there any way?