Some test cases in GeoTiffWriteReadTest fails assertion if java -enableassertions switch is turned on

kygoh · June 21, 2019, 4:10am

I can pass all tests org.esa.snap.dataio.geotiffGeoTiffWriteReadTest from maven command line.

However, I stumbled on this problem when running org.esa.snap.dataio.geotiffGeoTiffWriteReadTest on eclipse. By default, my eclipse turns on java enable assertions switch.

When the enable assertions switch is turned on the following test cases will fail:

testWriteReadUTMProjection
testWriteReadTransverseMercator
testWriteReadLambertConformalConic

The same test cases will fail in maven command line if enable assertions switch is turned on through maven surefire enableAssertions flag.

The assertion is caught by:

github.com

geotools/geotools/blob/17.1/modules/library/referencing/src/main/java/org/geotools/referencing/operation/projection/MapProjection.java#L1070


      
               */
              final double x = toDegrees(centralMeridian != 0 ?
                               rollLongitude(ptDst.getX() + centralMeridian) : ptDst.getX());
              final double y = toDegrees(ptDst.getY());
              ptDst.setLocation(x,y);
              if (verifyCoordinateRanges()) {
                  if (verifyGeographicRanges(this, x, y)) {
                      warningLogged();
                  }
              }
              assert checkReciprocal(ptDst, (ptSrc!=ptDst) ? ptSrc : new Point2D.Double(x0, y0), false);
              return ptDst;
          }
          
          /**
           * Inverse transforms a list of coordinate point ordinal values.
           * Ordinates must be (<var>x</var>,<var>y</var>) pairs in metres.
           *
           * @throws ProjectionException if a point can't be transformed. This method tries
           *         to transform every points even if some of them can't be transformed.
           *         Non-transformable points will have value {@link Double#NaN}. If more

Upon further checking, the assertion for testWriteReadUTMProjection and testWriteReadTransverseMercator were caused by the following Affine Transform operations:

github.com

senbox-org/snap-engine/blob/master/snap-geotiff/src/test/java/org/esa/snap/dataio/geotiff/GeoTiffWriteReadTest.java#L420-L422


      
          GeoPos geoPos1 = null;
          GeoPos geoPos2 = null;
          final String msgPattern = "%s at [%d,%d] is not equal:";

while testWriteReadLambertConformalConic was caused by similar Affine Transform operations:

github.com

senbox-org/snap-engine/blob/master/snap-geotiff/src/test/java/org/esa/snap/dataio/geotiff/GeoTiffWriteReadTest.java#L458-L460


      
          private static void setGeoCoding(Product product, String epsgCode) throws FactoryException, TransformException {
              final CoordinateReferenceSystem crs = CRS.decode(epsgCode, true);
              final Rectangle imageBounds = new Rectangle(product.getSceneRasterWidth(), product.getSceneRasterHeight());

I could make the assertion pass for testWriteReadUTMProjection and testWriteReadTransverseMercator by reducing the Affine Transform operations to

imageToMap.translate(827933.23, 3729820.29);

However, I couldn’t find Affine Transform operation to pass the assertion for testWriteReadLambertConformalConic.

Can anyone help?

marpet · June 21, 2019, 6:44am

Hi,

because of the assertion we disabled them in the pom.xml.

github.com

senbox-org/snap-engine/blob/410f116c067625c2d66472e0c2d87e41c0db1625/pom.xml#L835-L841


<configuration>
    <!--
         If enabled some assertions in GeoTools fail.
         Disabling helps to have a successful build.
         But it might indicate some problem.
    -->
    <enableAssertions>false</enableAssertions>

To my understanding the assertions, used by GeoTools, are not necessary. The working test with assertions disabled, proofs this.
The assertions are also not enabled when running SNAP. So I think it is okay as it is.